Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Topic/fix xunit warnings #333

Merged
merged 7 commits into from Sep 13, 2019
Merged

Topic/fix xunit warnings #333

merged 7 commits into from Sep 13, 2019

Conversation

biohazard999
Copy link
Contributor

fixes #332

@laedit
Copy link
Member

laedit commented Sep 13, 2019

Thanks!

There is still a xunit warning on appveyor build:

xUnit1013: Public method 'When' on test class 'SpecificationFor' should be marked as a Fact.

Is it possible to indicate to xunit that this is normal?

@biohazard999
Copy link
Contributor Author

Thanks!

There is still a xunit warning on appveyor build:

xUnit1013: Public method 'When' on test class 'SpecificationFor' should be marked as a Fact.

Is it possible to indicate to xunit that this is normal?

I can supress it. Adding the [Fact] didn't change it. Seams like a bug in the analyzer

@laedit
Copy link
Member

laedit commented Sep 13, 2019

Perfect, thanks a lot!

@laedit laedit merged commit e4d949c into Code52:master Sep 13, 2019
@biohazard999 biohazard999 deleted the topic/fix-xunit-warnings branch September 13, 2019 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laedit laedit laedit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix warnings in tests produced by xunit analyzer
2 participants
@biohazard999 @laedit